Replace AMS1117 5V-3.3V LDO on NodeMCU for LiPo with low quiescent current

You choice looks good to me, but only if your NodeMCU is going to spend most of its time sleeping. In that case I'd use a MCP1700 (quiescent current < 4 uA).

If it's going to spend a significant % of time up and running you may be better off using a switching regulator. It's all about considering the energy saved when it's sleeping vs. the energy saved when it's operating.

FYI, the Diodes Inc AP7361C-33ER has the same pin-out, 1A current capacity, 360mV drop-out (so can generally be used with LiPo), 60uA Iq (pretty good for a 1A LDO). $0.62 qty1 in stock at Digikey. There are many other choices in LDOs but very few that are pin-compatible and have high current capacity, e.g., the MCP1700 is 250mA in comparison. Of course it all depends on what you need...